Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
D
dex
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
go
dex
Commits
99370b58
Commit
99370b58
authored
Aug 18, 2017
by
Chien Huey
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Updated comment to include reference to GitHub Enterprise not supporting verified emails
parent
98f6a217
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
10 additions
and
1 deletion
+10
-1
github.go
connector/github/github.go
+10
-1
No files found.
connector/github/github.go
View file @
99370b58
...
@@ -503,7 +503,16 @@ func (c *githubConnector) userEmail(ctx context.Context, client *http.Client) (s
...
@@ -503,7 +503,16 @@ func (c *githubConnector) userEmail(ctx context.Context, client *http.Client) (s
}
}
for
_
,
email
:=
range
emails
{
for
_
,
email
:=
range
emails
{
// if GitHub Enterprise, set email.Verified to true
/*
if GitHub Enterprise, set email.Verified to true
This change being made because GitHub Enterprise does not
support email verification. CircleCI indicated that GitHub
advised them not to check for verified emails
(https://circleci.com/enterprise/changelog/#1-47-1).
In addition, GitHub Enterprise support replied to a support
ticket with "There is no way to verify an email address in
GitHub Enterprise."
*/
if
c
.
hostName
!=
""
{
if
c
.
hostName
!=
""
{
email
.
Verified
=
true
email
.
Verified
=
true
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment