Skip to content

D
dex
Commit b84721cb authored by Eric Stroczynski's avatar Eric Stroczynski Committed by GitHub
Browse files
Options

Merge pull request #1035 from estroz/user-login-github-patch 

connector/github: fix username used when making API requests
parents 7e580ec2 484327fd
Show whitespace changes
Inline Side-by-side
Showing with 6 additions and 6 deletions
connector/github/github.go
View file @ b84721cb
...@@ -247,16 +247,16 @@ func (c *githubConnector) HandleCallback(s connector.Scopes, r *http.Request) (i ...@@ -247,16 +247,16 @@ func (c *githubConnector) HandleCallback(s connector.Scopes, r *http.Request) (i
if s.Groups { if s.Groups {
var groups []string var groups []string
if len(c.orgs) > 0 { if len(c.orgs) > 0 {
if groups, err = c.listGroups(ctx, client, username); err != nil { if groups, err = c.listGroups(ctx, client, user.Login); err != nil {
return identity, err return identity, err
} }
} else if c.org != "" { } else if c.org != "" {
inOrg, err := c.userInOrg(ctx, client, username, c.org) inOrg, err := c.userInOrg(ctx, client, user.Login, c.org)
if err != nil { if err != nil {
return identity, err return identity, err
} }
if !inOrg { if !inOrg {
return identity, fmt.Errorf("github: user %q not a member of org %q", username, c.org) return identity, fmt.Errorf("github: user %q not a member of org %q", user.Login, c.org)
} }
if groups, err = c.teams(ctx, client, c.org); err != nil { if groups, err = c.teams(ctx, client, c.org); err != nil {
return identity, fmt.Errorf("github: get teams: %v", err) return identity, fmt.Errorf("github: get teams: %v", err)
...@@ -303,16 +303,16 @@ func (c *githubConnector) Refresh(ctx context.Context, s connector.Scopes, ident ...@@ -303,16 +303,16 @@ func (c *githubConnector) Refresh(ctx context.Context, s connector.Scopes, ident
if s.Groups { if s.Groups {
var groups []string var groups []string
if len(c.orgs) > 0 { if len(c.orgs) > 0 {
if groups, err = c.listGroups(ctx, client, username); err != nil { if groups, err = c.listGroups(ctx, client, user.Login); err != nil {
return identity, err return identity, err
} }
} else if c.org != "" { } else if c.org != "" {
inOrg, err := c.userInOrg(ctx, client, username, c.org) inOrg, err := c.userInOrg(ctx, client, user.Login, c.org)
if err != nil { if err != nil {
return identity, err return identity, err
} }
if !inOrg { if !inOrg {
return identity, fmt.Errorf("github: user %q not a member of org %q", username, c.org) return identity, fmt.Errorf("github: user %q not a member of org %q", user.Login, c.org)
} }
if groups, err = c.teams(ctx, client, c.org); err != nil { if groups, err = c.teams(ctx, client, c.org); err != nil {
return identity, fmt.Errorf("github: get teams: %v", err) return identity, fmt.Errorf("github: get teams: %v", err)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment