Commit cc7d6979 authored by Martin Sefcik's avatar Martin Sefcik

Removed pointers

parent 261b930b
...@@ -169,13 +169,13 @@ type CommitComment struct { ...@@ -169,13 +169,13 @@ type CommitComment struct {
type Author struct { type Author struct {
ID *int `json:"id"` ID int `json:"id"`
Username *string `json:"username"` Username string `json:"username"`
Email *string `json:"email"` Email string `json:"email"`
Name *string `json:"name"` Name string `json:"name"`
State *string `json:"state"` State string `json:"state"`
Blocked *bool `json:"blocked"` Blocked bool `json:"blocked"`
CreatedAt *time.Time `json:"created_at"` CreatedAt time.Time `json:"created_at"`
} }
func (c CommitComment) String() string { func (c CommitComment) String() string {
...@@ -255,34 +255,36 @@ func (s *CommitsService) PostCommitComment( ...@@ -255,34 +255,36 @@ func (s *CommitsService) PostCommitComment(
// //
// GitLab API docs: http://doc.gitlab.com/ce/api/commits.html#get-the-status-of-a-commit // GitLab API docs: http://doc.gitlab.com/ce/api/commits.html#get-the-status-of-a-commit
type GetCommitStatusesOptions struct { type GetCommitStatusesOptions struct {
Ref string `url:"ref,omitempty"` Ref string `url:"ref,omitempty" json:"ref,omitempty"`
Stage string `url:"stage,omitempty"` Stage string `url:"stage,omitempty" json:"stage,omitempty"`
Name string `url:"name,omitempty"` Name string `url:"name,omitempty" json:"name,omitempty"`
All bool `url:"all,omitempty"` All bool `url:"all,omitempty" json:"all,omitempty"`
} }
// CommitStatus represents a GitLab commit status. // CommitStatus represents a GitLab commit status.
// //
// GitLab API docs: http://doc.gitlab.com/ce/api/commits.html#get-the-status-of-a-commit // GitLab API docs: http://doc.gitlab.com/ce/api/commits.html#get-the-status-of-a-commit
type CommitStatus struct { type CommitStatus struct {
ID *int `json:"id"` ID int `json:"id"`
SHA *string `json:"sha"` SHA string `json:"sha"`
Ref *string `json:"ref"` Ref string `json:"ref"`
Status *string `json:"status"` Status string `json:"status"`
Name *string `json:"name"` Name string `json:"name"`
TargetUrl *string `json:"target_url"` TargetUrl string `json:"target_url"`
Description *string `json:"description"` Description string `json:"description"`
CreatedAt *time.Time `json:"created_at"` CreatedAt time.Time `json:"created_at"`
StartedAt *time.Time `json:"started_at"` StartedAt time.Time `json:"started_at"`
FinishedAt *time.Time `json:"finished_at"` FinishedAt time.Time `json:"finished_at"`
Author *Author `json:"author"` Author Author `json:"author"`
} }
// GetCommitStatuses gets the statuses of a commit in a project. // GetCommitStatuses gets the statuses of a commit in a project.
// //
// GitLab API docs: http://doc.gitlab.com/ce/api/commits.html#get-the-status-of-a-commit // GitLab API docs: http://doc.gitlab.com/ce/api/commits.html#get-the-status-of-a-commit
func (s *CommitsService) GetCommitStatuses( func (s *CommitsService) GetCommitStatuses(
pid interface{}, sha string, opt *GetCommitStatusesOptions) ([]*CommitStatus, *Response, error) { pid interface{},
sha string,
opt *GetCommitStatusesOptions) ([]*CommitStatus, *Response, error) {
project, err := parseID(pid) project, err := parseID(pid)
if err != nil { if err != nil {
return nil, nil, err return nil, nil, err
...@@ -329,8 +331,9 @@ const ( ...@@ -329,8 +331,9 @@ const (
// //
// GitLab API docs: http://doc.gitlab.com/ce/api/commits.html#post-the-status-to-commit // GitLab API docs: http://doc.gitlab.com/ce/api/commits.html#post-the-status-to-commit
func (s *CommitsService) SetCommitStatus( func (s *CommitsService) SetCommitStatus(
pid interface{}, pid interface{},
sha string, opt *SetCommitStatusOptions) (*CommitStatus, *Response, error) { sha string,
opt *SetCommitStatusOptions) (*CommitStatus, *Response, error) {
project, err := parseID(pid) project, err := parseID(pid)
if err != nil { if err != nil {
return nil, nil, err return nil, nil, err
......
...@@ -29,7 +29,7 @@ func TestGetCommitStatuses(t *testing.T) { ...@@ -29,7 +29,7 @@ func TestGetCommitStatuses(t *testing.T) {
t.Errorf("Commits.GetCommitStatuses returned error: %v", err) t.Errorf("Commits.GetCommitStatuses returned error: %v", err)
} }
want := []*CommitStatus{{ID: Int(1)}} want := []*CommitStatus{{ID: 1}}
if !reflect.DeepEqual(want, statuses) { if !reflect.DeepEqual(want, statuses) {
t.Errorf("Commits.GetCommitStatuses returned %+v, want %+v", statuses, want) t.Errorf("Commits.GetCommitStatuses returned %+v, want %+v", statuses, want)
} }
...@@ -58,7 +58,7 @@ func TestSetCommitStatus(t *testing.T) { ...@@ -58,7 +58,7 @@ func TestSetCommitStatus(t *testing.T) {
t.Errorf("Commits.SetCommitStatus returned error: %v", err) t.Errorf("Commits.SetCommitStatus returned error: %v", err)
} }
want := &CommitStatus{ID: Int(1)} want := &CommitStatus{ID: 1}
if !reflect.DeepEqual(want, status) { if !reflect.DeepEqual(want, status) {
t.Errorf("Commits.SetCommitStatus returned %+v, want %+v", status, want) t.Errorf("Commits.SetCommitStatus returned %+v, want %+v", status, want)
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment