• Giovanni Bajo's avatar
    test: relax whitespaces matching in codegen tests · f02cc88f
    Giovanni Bajo authored
    The codegen testsuite uses regexp to parse the syntax, but it doesn't
    have a way to tell line comments containing checks from line comments
    containing English sentences. This means that any syntax error (that
    is, non-matching regexp) is currently ignored and not reported.
    
    There were some tests in memcombine.go that had an extraneous space
    and were thus effectively disabled. It would be great if we could
    report it as a syntax error, but for now we just punt and swallow the
    spaces as a workaround, to avoid the same mistake again.
    
    Fixes #25452
    
    Change-Id: Ic7747a2278bc00adffd0c199ce40937acbbc9cf0
    Reviewed-on: https://go-review.googlesource.com/113835
    Run-TryBot: Giovanni Bajo <rasky@develer.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarKeith Randall <khr@golang.org>
    f02cc88f
memcombine.go 18.5 KB