Commit 0bede7f3 authored by Austin Clements's avatar Austin Clements Committed by David Chase

cmd/compile: split TestNexting into subtests

This makes it more obvious which of the two builds is failing by
putting "dbg" or "opt" directly in the test name. It also makes it
possible for them to fail independently, so a failure in "dbg" doesn't
mask a failure in "opt", and to visibly skip the opt test when run
with an unoptimized runtime.

Change-Id: I3403a7fd3c1a13ad51a938bb95dfe54c320bb58e
Reviewed-on: https://go-review.googlesource.com/69970
Run-TryBot: Austin Clements <austin@google.com>
Reviewed-by: 's avatarHeschi Kreinick <heschi@google.com>
parent 0aef82aa
......@@ -98,12 +98,18 @@ func TestNexting(t *testing.T) {
}
}
t.Run("dbg", func(t *testing.T) {
testNexting(t, "hist", "dbg", "-N -l")
})
t.Run("opt", func(t *testing.T) {
// If this is test is run with a runtime compiled with -N -l, it is very likely to fail.
// This occurs in the noopt builders (for example).
if gogcflags := os.Getenv("GO_GCFLAGS"); *force || !strings.Contains(gogcflags, "-N") && !strings.Contains(gogcflags, "-l") {
if gogcflags := os.Getenv("GO_GCFLAGS"); *force || (!strings.Contains(gogcflags, "-N") && !strings.Contains(gogcflags, "-l")) {
testNexting(t, "hist", "opt", "")
} else {
t.Skip("skipping for unoptimized runtime")
}
})
}
func testNexting(t *testing.T, base, tag, gcflags string) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment