Commit 12cf1699 authored by Brad Fitzpatrick's avatar Brad Fitzpatrick

net: default to 127.0.0.1, not localhost, in TestICMP

If localhost resolves to ::1, the IPv4-only test fails.

R=rsc, r2
CC=golang-dev
https://golang.org/cl/4444084
parent 6876ad37
...@@ -60,7 +60,8 @@ func parsePingReply(p []byte) (id, seq int) { ...@@ -60,7 +60,8 @@ func parsePingReply(p []byte) (id, seq int) {
} }
var srchost = flag.String("srchost", "", "Source of the ICMP ECHO request") var srchost = flag.String("srchost", "", "Source of the ICMP ECHO request")
var dsthost = flag.String("dsthost", "localhost", "Destination for the ICMP ECHO request") // 127.0.0.1 because this is an IPv4-specific test.
var dsthost = flag.String("dsthost", "127.0.0.1", "Destination for the ICMP ECHO request")
// test (raw) IP socket using ICMP // test (raw) IP socket using ICMP
func TestICMP(t *testing.T) { func TestICMP(t *testing.T) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment