Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
G
golang
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
go
golang
Commits
152bfa03
Commit
152bfa03
authored
Nov 17, 2009
by
Devon H. O'Dell
Committed by
Russ Cox
Nov 17, 2009
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Pass ui into PostMessage to avoid nasty/confusing exception
R=rsc
https://golang.org/cl/155079
parent
0489a260
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
4 deletions
+4
-4
codereview.py
lib/codereview/codereview.py
+4
-4
No files found.
lib/codereview/codereview.py
View file @
152bfa03
...
...
@@ -702,7 +702,7 @@ def change(ui, repo, *pats, **opts):
if
opts
[
"delete"
]:
if
cl
.
original_author
:
return
"original author must delete CL; hg change -D will remove locally"
PostMessage
(
cl
.
name
,
"*** Abandoned ***"
,
send_mail
=
"checked"
)
PostMessage
(
ui
,
cl
.
name
,
"*** Abandoned ***"
,
send_mail
=
"checked"
)
EditDesc
(
cl
.
name
,
closed
=
"checked"
)
cl
.
Delete
(
ui
,
repo
)
return
...
...
@@ -903,7 +903,7 @@ def mail(ui, repo, *pats, **opts):
pmsg
+=
",
\n
"
pmsg
+=
"
\n
"
pmsg
+=
"I'd like you to review the following change.
\n
"
PostMessage
(
cl
.
name
,
pmsg
,
send_mail
=
"checked"
,
subject
=
cl
.
Subject
())
PostMessage
(
ui
,
cl
.
name
,
pmsg
,
send_mail
=
"checked"
,
subject
=
cl
.
Subject
())
def
nocommit
(
ui
,
repo
,
*
pats
,
**
opts
):
"""(disabled when using this extension)"""
...
...
@@ -1059,7 +1059,7 @@ def submit(ui, repo, *pats, **opts):
else
:
print
>>
sys
.
stderr
,
"URL: "
,
url
pmsg
=
"*** Submitted as "
+
changeURL
+
" ***
\n\n
"
+
opts
[
'message'
]
PostMessage
(
cl
.
name
,
pmsg
,
send_mail
=
"checked"
)
PostMessage
(
ui
,
cl
.
name
,
pmsg
,
send_mail
=
"checked"
)
if
not
cl
.
original_author
:
EditDesc
(
cl
.
name
,
closed
=
"checked"
)
cl
.
Delete
(
ui
,
repo
)
...
...
@@ -1517,7 +1517,7 @@ def PostMessage1(issue, message, reviewers=None, cc=None, send_mail=None, subjec
print
response
sys
.
exit
(
2
)
def
PostMessage
(
issue
,
message
,
reviewers
=
None
,
cc
=
None
,
send_mail
=
None
,
subject
=
None
):
def
PostMessage
(
ui
,
issue
,
message
,
reviewers
=
None
,
cc
=
None
,
send_mail
=
None
,
subject
=
None
):
# When Rietveld is busy, it seems to throw off a lot of HTTP Error 500: Internal Server Error.
# Rather than abort, sleep and try again.
# Even if the second time fails, let the overall hg command keep going.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment