Commit 84a36434 authored by Russ Cox's avatar Russ Cox

runtime: fix nacl amd64p32 flakiness

newproc takes two extra pointers, not two extra registers.
On amd64p32 (nacl) they are different.

We diagnosed this before the 1.3 cut but the tree was frozen.
I believe this is causing the random problems on the builder.

Fixes #8199.

TBR=r
CC=golang-codereviews
https://golang.org/cl/102710043
parent ea0fb5d8
...@@ -214,7 +214,7 @@ runtime·gentraceback(uintptr pc0, uintptr sp0, uintptr lr0, G *gp, int32 skip, ...@@ -214,7 +214,7 @@ runtime·gentraceback(uintptr pc0, uintptr sp0, uintptr lr0, G *gp, int32 skip,
// the SP is two words lower than normal. // the SP is two words lower than normal.
sparg = frame.sp; sparg = frame.sp;
if(wasnewproc) if(wasnewproc)
sparg += 2*sizeof(uintreg); sparg += 2*sizeof(uintptr);
// Determine frame's 'continuation PC', where it can continue. // Determine frame's 'continuation PC', where it can continue.
// Normally this is the return address on the stack, but if sigpanic // Normally this is the return address on the stack, but if sigpanic
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment