Commit beceea73 authored by Brad Fitzpatrick's avatar Brad Fitzpatrick

runtime/pprof: mark dragonfly and solaris as bad at pprof

Updates #13841

Change-Id: I121bce054e2756c820c76444e51357f474b7f3d6
Reviewed-on: https://go-review.googlesource.com/19161Reviewed-by: 's avatarRuss Cox <rsc@golang.org>
parent 2639498f
...@@ -96,7 +96,7 @@ func parseProfile(t *testing.T, bytes []byte, f func(uintptr, []uintptr)) { ...@@ -96,7 +96,7 @@ func parseProfile(t *testing.T, bytes []byte, f func(uintptr, []uintptr)) {
if l < 5+3 { if l < 5+3 {
t.Logf("profile too short: %#x", val) t.Logf("profile too short: %#x", val)
if badOS[runtime.GOOS] { if badOS[runtime.GOOS] {
t.Skipf("ignoring failure on %s; see golang.org/issue/6047", runtime.GOOS) t.Skipf("ignoring failure on %s; see golang.org/issue/13841", runtime.GOOS)
return return
} }
t.FailNow() t.FailNow()
...@@ -171,7 +171,7 @@ func testCPUProfile(t *testing.T, need []string, f func(dur time.Duration)) { ...@@ -171,7 +171,7 @@ func testCPUProfile(t *testing.T, need []string, f func(dur time.Duration)) {
} }
if badOS[runtime.GOOS] { if badOS[runtime.GOOS] {
t.Skipf("ignoring failure on %s; see golang.org/issue/6047", runtime.GOOS) t.Skipf("ignoring failure on %s; see golang.org/issue/13841", runtime.GOOS)
return return
} }
// Ignore the failure if the tests are running in a QEMU-based emulator, // Ignore the failure if the tests are running in a QEMU-based emulator,
...@@ -420,11 +420,13 @@ func deepStack(depth int) int { ...@@ -420,11 +420,13 @@ func deepStack(depth int) int {
return deepStack(depth-1) + 1 return deepStack(depth-1) + 1
} }
// Operating systems that are expected to fail the tests. See issue 6047. // Operating systems that are expected to fail the tests. See issue 13841.
var badOS = map[string]bool{ var badOS = map[string]bool{
"darwin": true, "darwin": true,
"netbsd": true, "netbsd": true,
"plan9": true, "plan9": true,
"dragonfly": true,
"solaris": true,
} }
func TestBlockProfile(t *testing.T) { func TestBlockProfile(t *testing.T) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment