Commit c6f23bb7 authored by Rob Pike's avatar Rob Pike

image/png: use Scanner in reader_test.

R=nigeltao
CC=golang-dev
https://golang.org/cl/7399044
parent f7a77163
...@@ -208,7 +208,7 @@ func TestReader(t *testing.T) { ...@@ -208,7 +208,7 @@ func TestReader(t *testing.T) {
} }
piper, pipew := io.Pipe() piper, pipew := io.Pipe()
pb := bufio.NewReader(piper) pb := bufio.NewScanner(piper)
go sng(pipew, fn, img) go sng(pipew, fn, img)
defer piper.Close() defer piper.Close()
...@@ -219,7 +219,7 @@ func TestReader(t *testing.T) { ...@@ -219,7 +219,7 @@ func TestReader(t *testing.T) {
continue continue
} }
defer sf.Close() defer sf.Close()
sb := bufio.NewReader(sf) sb := bufio.NewScanner(sf)
if err != nil { if err != nil {
t.Error(fn, err) t.Error(fn, err)
continue continue
...@@ -227,24 +227,28 @@ func TestReader(t *testing.T) { ...@@ -227,24 +227,28 @@ func TestReader(t *testing.T) {
// Compare the two, in SNG format, line by line. // Compare the two, in SNG format, line by line.
for { for {
ps, perr := pb.ReadString('\n') pdone := pb.Scan()
ss, serr := sb.ReadString('\n') sdone := sb.Scan()
if perr == io.EOF && serr == io.EOF { if pdone && sdone {
break break
} }
if perr != nil { if pdone || sdone {
t.Error(fn, perr) t.Errorf("%s: Different sizes", fn)
break
}
if serr != nil {
t.Error(fn, serr)
break break
} }
ps := pb.Text()
ss := sb.Text()
if ps != ss { if ps != ss {
t.Errorf("%s: Mismatch\n%sversus\n%s\n", fn, ps, ss) t.Errorf("%s: Mismatch\n%sversus\n%s\n", fn, ps, ss)
break break
} }
} }
if pb.Err() != nil {
t.Error(fn, pb.Err())
}
if sb.Err() != nil {
t.Error(fn, sb.Err())
}
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment