Commit e26f9b34 authored by Rob Pike's avatar Rob Pike

flag: fix format error in boolean error report. just use %q; the values are strings.

R=rsc
CC=golang-dev
https://golang.org/cl/3418043
parent 730e39cd
...@@ -459,7 +459,7 @@ func (f *allFlags) parseOne(index int) (ok bool, next int) { ...@@ -459,7 +459,7 @@ func (f *allFlags) parseOne(index int) (ok bool, next int) {
if f, ok := flag.Value.(*boolValue); ok { // special case: doesn't need an arg if f, ok := flag.Value.(*boolValue); ok { // special case: doesn't need an arg
if has_value { if has_value {
if !f.Set(value) { if !f.Set(value) {
fmt.Fprintf(os.Stderr, "invalid boolean value %t for flag: -%s\n", value, name) fmt.Fprintf(os.Stderr, "invalid boolean value %q for flag: -%s\n", value, name)
fail() fail()
} }
} else { } else {
...@@ -479,7 +479,7 @@ func (f *allFlags) parseOne(index int) (ok bool, next int) { ...@@ -479,7 +479,7 @@ func (f *allFlags) parseOne(index int) (ok bool, next int) {
} }
ok = flag.Value.Set(value) ok = flag.Value.Set(value)
if !ok { if !ok {
fmt.Fprintf(os.Stderr, "invalid value %s for flag: -%s\n", value, name) fmt.Fprintf(os.Stderr, "invalid value %q for flag: -%s\n", value, name)
fail() fail()
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment