Commit fbd09150 authored by Russ Cox's avatar Russ Cox

crypto/sha256, crypto/sha512: fix argument size in assembly

The function takes 32 bytes of arguments: 8 for the *block
and then 3*8 for the slice.

The 24 is not causing a bug (today at least) because the
final word is the cap of the slice, which the assembly
does not use.

Identified by 'go vet std'.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/96360043
parent 435ba129
...@@ -140,7 +140,7 @@ ...@@ -140,7 +140,7 @@
MSGSCHEDULE1(index); \ MSGSCHEDULE1(index); \
SHA256ROUND(index, const, a, b, c, d, e, f, g, h) SHA256ROUND(index, const, a, b, c, d, e, f, g, h)
TEXT ·block(SB),0,$264-24 TEXT ·block(SB),0,$264-32
MOVQ p_base+8(FP), SI MOVQ p_base+8(FP), SI
MOVQ p_len+16(FP), DX MOVQ p_len+16(FP), DX
SHRQ $6, DX SHRQ $6, DX
......
...@@ -141,7 +141,7 @@ ...@@ -141,7 +141,7 @@
MSGSCHEDULE1(index); \ MSGSCHEDULE1(index); \
SHA512ROUND(index, const, a, b, c, d, e, f, g, h) SHA512ROUND(index, const, a, b, c, d, e, f, g, h)
TEXT ·block(SB),0,$648-24 TEXT ·block(SB),0,$648-32
MOVQ p_base+8(FP), SI MOVQ p_base+8(FP), SI
MOVQ p_len+16(FP), DX MOVQ p_len+16(FP), DX
SHRQ $7, DX SHRQ $7, DX
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment