• Alex Brainman's avatar
    cmd/link: do not use _GLOBAL_OFFSET_TABLE_ on windows/386 · 41fd4c88
    Alex Brainman authored
    When building windows/386 executable that imports "plugin" package,
    cmd/link adds reference to DLL with blank name. Running
    
    objdump -x a.exe
    
    reports
    
    ...
    The Import Tables (interpreted .idata section contents)
    ...
    DLL Name:
    vma:  Hint/Ord Member-Name Bound-To
    25308a     0  _GLOBAL_OFFSET_TABLE_
    ...
    
    So, obviously, executable cannot run, because Windows complains
    that it cannot find DLL when trying to run it.
    
    Stop using _GLOBAL_OFFSET_TABLE_ on windows/386.
    
    Fixes #28789
    
    Change-Id: Idd489eafd998f6e329f40c5d90a2a8965ab1d873
    Reviewed-on: https://go-review.googlesource.com/c/151139
    Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
    41fd4c88
Name
Last commit
Last update
.github Loading commit data...
api Loading commit data...
doc Loading commit data...
lib/time Loading commit data...
misc Loading commit data...
src Loading commit data...
test Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
AUTHORS Loading commit data...
CONTRIBUTING.md Loading commit data...
CONTRIBUTORS Loading commit data...
LICENSE Loading commit data...
PATENTS Loading commit data...
README.md Loading commit data...
favicon.ico Loading commit data...
robots.txt Loading commit data...