• Alex Brainman's avatar
    cmd/link: do not use _GLOBAL_OFFSET_TABLE_ on windows/386 · 41fd4c88
    Alex Brainman authored
    When building windows/386 executable that imports "plugin" package,
    cmd/link adds reference to DLL with blank name. Running
    
    objdump -x a.exe
    
    reports
    
    ...
    The Import Tables (interpreted .idata section contents)
    ...
    DLL Name:
    vma:  Hint/Ord Member-Name Bound-To
    25308a     0  _GLOBAL_OFFSET_TABLE_
    ...
    
    So, obviously, executable cannot run, because Windows complains
    that it cannot find DLL when trying to run it.
    
    Stop using _GLOBAL_OFFSET_TABLE_ on windows/386.
    
    Fixes #28789
    
    Change-Id: Idd489eafd998f6e329f40c5d90a2a8965ab1d873
    Reviewed-on: https://go-review.googlesource.com/c/151139
    Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
    41fd4c88
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testdata Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...