Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
H
helm3
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
go
helm3
Commits
18f900e4
Commit
18f900e4
authored
May 22, 2017
by
Sushil Kumar
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Errors out if install/upgrade fails to load-requirements
Fixes
https://github.com/kubernetes/helm/issues/2480
parent
d76c1049
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
0 deletions
+6
-0
install.go
cmd/helm/install.go
+2
-0
upgrade.go
cmd/helm/upgrade.go
+4
-0
No files found.
cmd/helm/install.go
View file @
18f900e4
...
@@ -232,6 +232,8 @@ func (i *installCmd) run() error {
...
@@ -232,6 +232,8 @@ func (i *installCmd) run() error {
if
err
:=
checkDependencies
(
chartRequested
,
req
,
i
.
out
);
err
!=
nil
{
if
err
:=
checkDependencies
(
chartRequested
,
req
,
i
.
out
);
err
!=
nil
{
return
prettyError
(
err
)
return
prettyError
(
err
)
}
}
}
else
if
err
!=
chartutil
.
ErrRequirementsNotFound
{
return
fmt
.
Errorf
(
"cannot load requirements: %v"
,
err
)
}
}
res
,
err
:=
i
.
client
.
InstallReleaseFromChart
(
res
,
err
:=
i
.
client
.
InstallReleaseFromChart
(
...
...
cmd/helm/upgrade.go
View file @
18f900e4
...
@@ -185,7 +185,11 @@ func (u *upgradeCmd) run() error {
...
@@ -185,7 +185,11 @@ func (u *upgradeCmd) run() error {
if
err
:=
checkDependencies
(
ch
,
req
,
u
.
out
);
err
!=
nil
{
if
err
:=
checkDependencies
(
ch
,
req
,
u
.
out
);
err
!=
nil
{
return
err
return
err
}
}
}
else
if
err
!=
chartutil
.
ErrRequirementsNotFound
{
return
fmt
.
Errorf
(
"cannot load requirements: %v"
,
err
)
}
}
}
else
{
return
prettyError
(
err
)
}
}
resp
,
err
:=
u
.
client
.
UpdateRelease
(
resp
,
err
:=
u
.
client
.
UpdateRelease
(
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment