Skip to content

H
helm3
Commit 1ced91bb authored by Matt Butcher's avatar Matt Butcher Committed by GitHub
Browse files
Options

Merge pull request #2676 from technosophos/fix/CONTRIBUTING-clarification-on-OWNERS 

fix(CONTRIBUTING): added note about who merges a PR
parents 04a0659b df13268e
Show whitespace changes
Inline Side-by-side
Showing with 4 additions and 0 deletions
CONTRIBUTING.md
View file @ 1ced91bb
...@@ -143,6 +143,10 @@ Like any good open source project, we use Pull Requests to track code changes ...@@ -143,6 +143,10 @@ Like any good open source project, we use Pull Requests to track code changes
- PRs should stay open until merged or if they have not been active for more than 30 days. - PRs should stay open until merged or if they have not been active for more than 30 days.
This will help keep the PR queue to a manageable size and reduce noise. Should the PR need This will help keep the PR queue to a manageable size and reduce noise. Should the PR need
to stay open (like in the case of a WIP), the `keep open` label can be added. to stay open (like in the case of a WIP), the `keep open` label can be added.
- If the owner of the PR is listed in `OWNERS`, that user **must** merge their own PRs
or explicitly request another OWNER do that for them.
- If the owner of a PR is _not_ listed in `OWNERS`, any core committer may
merge the PR once it is approved.
#### Documentation PRs #### Documentation PRs
Documentation PRs will follow the same lifecycle as other PRs. They will also be labeled with the Documentation PRs will follow the same lifecycle as other PRs. They will also be labeled with the
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment