Commit 3a483bcf authored by Matt Butcher's avatar Matt Butcher

feat(helm): make long listing default for helm list

This removes --long and adds --short,-q

The default listing is now the long listing, which matches the behavior
of all of the other listing commands.

Closes #1215
parent dbb84a1b
...@@ -58,7 +58,7 @@ flag with the '--offset' flag allows you to page through results. ...@@ -58,7 +58,7 @@ flag with the '--offset' flag allows you to page through results.
type listCmd struct { type listCmd struct {
filter string filter string
long bool short bool
limit int limit int
offset string offset string
byDate bool byDate bool
...@@ -94,7 +94,7 @@ func newListCmd(client helm.Interface, out io.Writer) *cobra.Command { ...@@ -94,7 +94,7 @@ func newListCmd(client helm.Interface, out io.Writer) *cobra.Command {
}, },
} }
f := cmd.Flags() f := cmd.Flags()
f.BoolVarP(&list.long, "long", "l", false, "output long listing format") f.BoolVarP(&list.short, "short", "q", false, "output short (quiet) listing format")
f.BoolVarP(&list.byDate, "date", "d", false, "sort by release date") f.BoolVarP(&list.byDate, "date", "d", false, "sort by release date")
f.BoolVarP(&list.sortDesc, "reverse", "r", false, "reverse the sort order") f.BoolVarP(&list.sortDesc, "reverse", "r", false, "reverse the sort order")
f.IntVarP(&list.limit, "max", "m", 256, "maximum number of releases to fetch") f.IntVarP(&list.limit, "max", "m", 256, "maximum number of releases to fetch")
...@@ -144,14 +144,13 @@ func (l *listCmd) run() error { ...@@ -144,14 +144,13 @@ func (l *listCmd) run() error {
rels := res.Releases rels := res.Releases
if l.long { if l.short {
fmt.Fprintln(l.out, formatList(rels))
return nil
}
for _, r := range rels { for _, r := range rels {
fmt.Fprintln(l.out, r.Name) fmt.Fprintln(l.out, r.Name)
} }
return nil
}
fmt.Fprintln(l.out, formatList(rels))
return nil return nil
} }
......
...@@ -40,8 +40,8 @@ func TestListCmd(t *testing.T) { ...@@ -40,8 +40,8 @@ func TestListCmd(t *testing.T) {
expected: "thomas-guide", expected: "thomas-guide",
}, },
{ {
name: "list --long", name: "list",
args: []string{"--long"}, args: []string{},
resp: []*release.Release{ resp: []*release.Release{
releaseMock(&releaseOptions{name: "atlas"}), releaseMock(&releaseOptions{name: "atlas"}),
}, },
...@@ -49,7 +49,7 @@ func TestListCmd(t *testing.T) { ...@@ -49,7 +49,7 @@ func TestListCmd(t *testing.T) {
}, },
{ {
name: "with a release, multiple flags", name: "with a release, multiple flags",
args: []string{"--deleted", "--deployed", "--failed"}, args: []string{"--deleted", "--deployed", "--failed", "-q"},
resp: []*release.Release{ resp: []*release.Release{
releaseMock(&releaseOptions{name: "thomas-guide", statusCode: release.Status_DELETED}), releaseMock(&releaseOptions{name: "thomas-guide", statusCode: release.Status_DELETED}),
releaseMock(&releaseOptions{name: "atlas-guide", statusCode: release.Status_DEPLOYED}), releaseMock(&releaseOptions{name: "atlas-guide", statusCode: release.Status_DEPLOYED}),
...@@ -60,7 +60,7 @@ func TestListCmd(t *testing.T) { ...@@ -60,7 +60,7 @@ func TestListCmd(t *testing.T) {
}, },
{ {
name: "with a release, multiple flags", name: "with a release, multiple flags",
args: []string{"--all"}, args: []string{"--all", "-q"},
resp: []*release.Release{ resp: []*release.Release{
releaseMock(&releaseOptions{name: "thomas-guide", statusCode: release.Status_DELETED}), releaseMock(&releaseOptions{name: "thomas-guide", statusCode: release.Status_DELETED}),
releaseMock(&releaseOptions{name: "atlas-guide", statusCode: release.Status_DEPLOYED}), releaseMock(&releaseOptions{name: "atlas-guide", statusCode: release.Status_DEPLOYED}),
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment