Unverified Commit 5437dd4d authored by Taylor Thomas's avatar Taylor Thomas Committed by GitHub

Merge pull request #5611 from cgetzen/cg/kube_create_goroutine

Performance: Batch kube API operations
parents ed8f17a8 6b2f408f
...@@ -26,6 +26,7 @@ import ( ...@@ -26,6 +26,7 @@ import (
"log" "log"
"sort" "sort"
"strings" "strings"
"sync"
"time" "time"
"k8s.io/apimachinery/pkg/api/meta" "k8s.io/apimachinery/pkg/api/meta"
...@@ -616,14 +617,35 @@ func perform(infos Result, fn ResourceActorFunc) error { ...@@ -616,14 +617,35 @@ func perform(infos Result, fn ResourceActorFunc) error {
return ErrNoObjectsVisited return ErrNoObjectsVisited
} }
for _, info := range infos { errs := make(chan error)
if err := fn(info); err != nil { go batchPerform(infos, fn, errs)
for range infos {
err := <-errs
if err != nil {
return err return err
} }
} }
return nil return nil
} }
func batchPerform(infos Result, fn ResourceActorFunc, errs chan<- error) {
var kind string
var wg sync.WaitGroup
for _, info := range infos {
currentKind := info.Object.GetObjectKind().GroupVersionKind().Kind
if kind != currentKind {
wg.Wait()
kind = currentKind
}
wg.Add(1)
go func(i *resource.Info) {
errs <- fn(i)
wg.Done()
}(info)
}
}
func createResource(info *resource.Info) error { func createResource(info *resource.Info) error {
obj, err := resource.NewHelper(info.Client, info.Mapping).Create(info.Namespace, true, info.Object, nil) obj, err := resource.NewHelper(info.Client, info.Mapping).Create(info.Namespace, true, info.Object, nil)
if err != nil { if err != nil {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment