Merge pull request #2673 from adamreese/fix/2630-helm-home

fix(helm): load home from flags during runtime

cmd/helm/create.go

@@ -62,9 +62,7 @@ type createCmd struct {
 }
 
 func newCreateCmd(out io.Writer) *cobra.Command {
-	cc := &createCmd{
-		out: out,
-	}
+	cc := &createCmd{out: out}
 
 	cmd := &cobra.Command{
 		Use:   "create NAME",

cmd/helm/dependency.go

@@ -108,9 +108,8 @@ type dependencyListCmd struct {
 }
 
 func newDependencyListCmd(out io.Writer) *cobra.Command {
-	dlc := &dependencyListCmd{
-		out: out,
-	}
+	dlc := &dependencyListCmd{out: out}
+
 	cmd := &cobra.Command{
 		Use:     "list [flags] CHART",
 		Aliases: []string{"ls"},

cmd/helm/dependency_build.go

@@ -45,9 +45,7 @@ type dependencyBuildCmd struct {
 }
 
 func newDependencyBuildCmd(out io.Writer) *cobra.Command {
-	dbc := &dependencyBuildCmd{
-		out: out,
-	}
+	dbc := &dependencyBuildCmd{out: out}
 
 	cmd := &cobra.Command{
 		Use:   "build [flags] CHART",

cmd/helm/dependency_update.go

@@ -52,9 +52,7 @@ type dependencyUpdateCmd struct {
 
 // newDependencyUpdateCmd creates a new dependency update command.
 func newDependencyUpdateCmd(out io.Writer) *cobra.Command {
-	duc := &dependencyUpdateCmd{
-		out: out,
-	}
+	duc := &dependencyUpdateCmd{out: out}
 
 	cmd := &cobra.Command{
 		Use:     "update [flags] CHART",

cmd/helm/init.go

@@ -82,9 +82,7 @@ type initCmd struct {
 }
 
 func newInitCmd(out io.Writer) *cobra.Command {
-	i := &initCmd{
-		out: out,
-	}
+	i := &initCmd{out: out}
 
 	cmd := &cobra.Command{
 		Use:   "init",

cmd/helm/package.go

@@ -64,9 +64,7 @@ type packageCmd struct {
 }
 
 func newPackageCmd(out io.Writer) *cobra.Command {
-	pkg := &packageCmd{
-		out: out,
-	}
+	pkg := &packageCmd{out: out}
 
 	cmd := &cobra.Command{
 		Use:   "package [flags] [CHART_PATH] [...]",

cmd/helm/repo_add.go

@@ -41,9 +41,7 @@ type repoAddCmd struct {
 }
 
 func newRepoAddCmd(out io.Writer) *cobra.Command {
-	add := &repoAddCmd{
-		out: out,
-	}
+	add := &repoAddCmd{out: out}
 
 	cmd := &cobra.Command{
 		Use:   "add [flags] [NAME] [URL]",

cmd/helm/repo_index.go

@@ -45,9 +45,7 @@ type repoIndexCmd struct {
 }
 
 func newRepoIndexCmd(out io.Writer) *cobra.Command {
-	index := &repoIndexCmd{
-		out: out,
-	}
+	index := &repoIndexCmd{out: out}
 
 	cmd := &cobra.Command{
 		Use:   "index [flags] [DIR]",

cmd/helm/repo_list.go

@@ -34,9 +34,7 @@ type repoListCmd struct {
 }
 
 func newRepoListCmd(out io.Writer) *cobra.Command {
-	list := &repoListCmd{
-		out: out,
-	}
+	list := &repoListCmd{out: out}
 
 	cmd := &cobra.Command{
 		Use:   "list [flags]",

cmd/helm/repo_remove.go

@@ -34,9 +34,7 @@ type repoRemoveCmd struct {
 }
 
 func newRepoRemoveCmd(out io.Writer) *cobra.Command {
-	remove := &repoRemoveCmd{
-		out: out,
-	}
+	remove := &repoRemoveCmd{out: out}
 
 	cmd := &cobra.Command{
 		Use:     "remove [flags] [NAME]",

cmd/helm/repo_update.go

@@ -37,9 +37,7 @@ Information is cached locally, where it is used by commands like 'helm search'.
 future releases.
 `
 
-var (
-	errNoRepositories = errors.New("no repositories found. You must add one before updating")
-)
+var errNoRepositories = errors.New("no repositories found. You must add one before updating")
 
 type repoUpdateCmd struct {
 	update func([]*repo.ChartRepository, io.Writer, helmpath.Home)

cmd/helm/search.go

@@ -50,13 +50,14 @@ type searchCmd struct {
 }
 
 func newSearchCmd(out io.Writer) *cobra.Command {
-	sc := &searchCmd{out: out, helmhome: settings.Home}
+	sc := &searchCmd{out: out}
 
 	cmd := &cobra.Command{
 		Use:   "search [keyword]",
 		Short: "search for a keyword in charts",
 		Long:  searchDesc,
 		RunE: func(cmd *cobra.Command, args []string) error {
+			sc.helmhome = settings.Home
 			return sc.run(args)
 		},
 	}