Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
H
helm3
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
go
helm3
Commits
8a13be29
Commit
8a13be29
authored
Nov 10, 2016
by
Rollulus
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix(helm): respect dryRun opt in DeleteRelease
parent
915769b3
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
5 additions
and
5 deletions
+5
-5
client.go
pkg/helm/client.go
+5
-5
No files found.
pkg/helm/client.go
View file @
8a13be29
...
@@ -89,6 +89,11 @@ func (h *Client) InstallRelease(chstr, ns string, opts ...InstallOption) (*rls.I
...
@@ -89,6 +89,11 @@ func (h *Client) InstallRelease(chstr, ns string, opts ...InstallOption) (*rls.I
// DeleteRelease uninstalls a named release and returns the response.
// DeleteRelease uninstalls a named release and returns the response.
func
(
h
*
Client
)
DeleteRelease
(
rlsName
string
,
opts
...
DeleteOption
)
(
*
rls
.
UninstallReleaseResponse
,
error
)
{
func
(
h
*
Client
)
DeleteRelease
(
rlsName
string
,
opts
...
DeleteOption
)
(
*
rls
.
UninstallReleaseResponse
,
error
)
{
// apply the uninstall options
for
_
,
opt
:=
range
opts
{
opt
(
&
h
.
opts
)
}
if
h
.
opts
.
dryRun
{
if
h
.
opts
.
dryRun
{
// In the dry run case, just see if the release exists
// In the dry run case, just see if the release exists
r
,
err
:=
h
.
ReleaseContent
(
rlsName
,
nil
)
r
,
err
:=
h
.
ReleaseContent
(
rlsName
,
nil
)
...
@@ -98,11 +103,6 @@ func (h *Client) DeleteRelease(rlsName string, opts ...DeleteOption) (*rls.Unins
...
@@ -98,11 +103,6 @@ func (h *Client) DeleteRelease(rlsName string, opts ...DeleteOption) (*rls.Unins
return
&
rls
.
UninstallReleaseResponse
{
Release
:
r
.
Release
},
nil
return
&
rls
.
UninstallReleaseResponse
{
Release
:
r
.
Release
},
nil
}
}
// apply the uninstall options
for
_
,
opt
:=
range
opts
{
opt
(
&
h
.
opts
)
}
req
:=
&
h
.
opts
.
uninstallReq
req
:=
&
h
.
opts
.
uninstallReq
req
.
Name
=
rlsName
req
.
Name
=
rlsName
req
.
DisableHooks
=
h
.
opts
.
disableHooks
req
.
DisableHooks
=
h
.
opts
.
disableHooks
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment