Skip to content

H
helm3
Commit e097e1b7 authored by Matt Butcher's avatar Matt Butcher Committed by GitHub
Browse files
Options

Merge pull request #1599 from technosophos/fix/1590-pass-no-hooks-to-server 

fix(helm): pass the no-hooks flag during upgrade
parents 3b4d7164 5f3d255e
Show whitespace changes
Inline Side-by-side
Showing with 7 additions and 1 deletion
cmd/helm/upgrade.go
View file @ e097e1b7
...@@ -135,7 +135,12 @@ func (u *upgradeCmd) run() error { ...@@ -135,7 +135,12 @@ func (u *upgradeCmd) run() error {
return err return err
} }
_, err = u.client.UpdateRelease(u.release, chartPath, helm.UpdateValueOverrides(rawVals), helm.UpgradeDryRun(u.dryRun), helm.UpgradeDisableHooks(u.disableHooks)) _, err = u.client.UpdateRelease(
u.release,
chartPath,
helm.UpdateValueOverrides(rawVals),
helm.UpgradeDryRun(u.dryRun),
helm.UpgradeDisableHooks(u.disableHooks))
if err != nil { if err != nil {
return fmt.Errorf("UPGRADE FAILED: %v", prettyError(err)) return fmt.Errorf("UPGRADE FAILED: %v", prettyError(err))
} }
......
pkg/helm/client.go
View file @ e097e1b7
...@@ -132,6 +132,7 @@ func (h *Client) UpdateRelease(rlsName string, chstr string, opts ...UpdateOptio ...@@ -132,6 +132,7 @@ func (h *Client) UpdateRelease(rlsName string, chstr string, opts ...UpdateOptio
req.Chart = chart req.Chart = chart
req.DryRun = h.opts.dryRun req.DryRun = h.opts.dryRun
req.Name = rlsName req.Name = rlsName
req.DisableHooks = h.opts.disableHooks
ctx := NewContext() ctx := NewContext()
if h.opts.before != nil { if h.opts.before != nil {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment