Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
H
helm3
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
go
helm3
Commits
ed9934ad
Unverified
Commit
ed9934ad
authored
May 06, 2019
by
Patrick Decat
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add test cases to reproduce issues with concurrent `helm repo add` commands
Signed-off-by:
Patrick Decat
<
pdecat@gmail.com
>
parent
b4ff4d2f
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
113 additions
and
0 deletions
+113
-0
repo_add_test.go
cmd/helm/repo_add_test.go
+113
-0
No files found.
cmd/helm/repo_add_test.go
View file @
ed9934ad
...
...
@@ -17,13 +17,18 @@ limitations under the License.
package
main
import
(
"fmt"
"io"
"os"
"os/exec"
"strings"
"sync"
"testing"
"github.com/spf13/cobra"
"k8s.io/helm/pkg/helm"
"k8s.io/helm/pkg/helm/helmpath"
"k8s.io/helm/pkg/repo"
"k8s.io/helm/pkg/repo/repotest"
)
...
...
@@ -101,3 +106,111 @@ func TestRepoAdd(t *testing.T) {
t
.
Errorf
(
"Duplicate repository name was added"
)
}
}
func
TestRepoAddConcurrentGoRoutines
(
t
*
testing
.
T
)
{
ts
,
thome
,
err
:=
repotest
.
NewTempServer
(
"testdata/testserver/*.*"
)
if
err
!=
nil
{
t
.
Fatal
(
err
)
}
cleanup
:=
resetEnv
()
defer
func
()
{
ts
.
Stop
()
os
.
RemoveAll
(
thome
.
String
())
cleanup
()
}()
settings
.
Home
=
thome
if
err
:=
ensureTestHome
(
settings
.
Home
,
t
);
err
!=
nil
{
t
.
Fatal
(
err
)
}
var
wg
sync
.
WaitGroup
wg
.
Add
(
3
)
for
i
:=
0
;
i
<
3
;
i
++
{
go
func
(
name
string
)
{
defer
wg
.
Done
()
if
err
:=
addRepository
(
name
,
ts
.
URL
(),
""
,
""
,
settings
.
Home
,
""
,
""
,
""
,
true
);
err
!=
nil
{
t
.
Error
(
err
)
}
}(
fmt
.
Sprintf
(
"%s-%d"
,
testName
,
i
))
}
wg
.
Wait
()
f
,
err
:=
repo
.
LoadRepositoriesFile
(
settings
.
Home
.
RepositoryFile
())
if
err
!=
nil
{
t
.
Error
(
err
)
}
var
name
string
for
i
:=
0
;
i
<
3
;
i
++
{
name
=
fmt
.
Sprintf
(
"%s-%d"
,
testName
,
i
)
if
!
f
.
Has
(
name
)
{
t
.
Errorf
(
"%s was not successfully inserted into %s"
,
name
,
settings
.
Home
.
RepositoryFile
())
}
}
}
// Same as TestRepoAddConcurrentGoRoutines but with repository additions in sub-processes
func
TestRepoAddConcurrentSubProcesses
(
t
*
testing
.
T
)
{
goWantHelperProcess
:=
os
.
Getenv
(
"GO_WANT_HELPER_PROCESS"
)
if
goWantHelperProcess
==
""
{
// parent
ts
,
thome
,
err
:=
repotest
.
NewTempServer
(
"testdata/testserver/*.*"
)
if
err
!=
nil
{
t
.
Fatal
(
err
)
}
settings
.
Home
=
thome
cleanup
:=
resetEnv
()
defer
func
()
{
ts
.
Stop
()
os
.
RemoveAll
(
thome
.
String
())
cleanup
()
}()
if
err
:=
ensureTestHome
(
settings
.
Home
,
t
);
err
!=
nil
{
t
.
Fatal
(
err
)
}
var
wg
sync
.
WaitGroup
wg
.
Add
(
3
)
for
i
:=
0
;
i
<
3
;
i
++
{
go
func
(
name
string
)
{
defer
wg
.
Done
()
cmd
:=
exec
.
Command
(
os
.
Args
[
0
],
"-test.run=^TestRepoAddConcurrentSubProcesses$"
)
cmd
.
Env
=
append
(
os
.
Environ
(),
fmt
.
Sprintf
(
"GO_WANT_HELPER_PROCESS=%s,%s"
,
name
,
ts
.
URL
()),
fmt
.
Sprintf
(
"HELM_HOME=%s"
,
settings
.
Home
))
out
,
err
:=
cmd
.
CombinedOutput
()
if
len
(
out
)
>
0
||
err
!=
nil
{
t
.
Fatalf
(
"child process: %q, %v"
,
out
,
err
)
}
}(
fmt
.
Sprintf
(
"%s-%d"
,
testName
,
i
))
}
wg
.
Wait
()
f
,
err
:=
repo
.
LoadRepositoriesFile
(
settings
.
Home
.
RepositoryFile
())
if
err
!=
nil
{
t
.
Error
(
err
)
}
var
name
string
for
i
:=
0
;
i
<
3
;
i
++
{
name
=
fmt
.
Sprintf
(
"%s-%d"
,
testName
,
i
)
if
!
f
.
Has
(
name
)
{
t
.
Errorf
(
"%s was not successfully inserted into %s"
,
name
,
settings
.
Home
.
RepositoryFile
())
}
}
}
else
{
// child
s
:=
strings
.
Split
(
goWantHelperProcess
,
","
)
settings
.
Home
=
helmpath
.
Home
(
os
.
Getenv
(
"HELM_HOME"
))
repoName
:=
s
[
0
]
tsURL
:=
s
[
1
]
if
err
:=
addRepository
(
repoName
,
tsURL
,
""
,
""
,
settings
.
Home
,
""
,
""
,
""
,
true
);
err
!=
nil
{
t
.
Fatal
(
err
)
}
os
.
Exit
(
0
)
}
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment