Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
B
beego
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
go
beego
Commits
85c0fcd3
Commit
85c0fcd3
authored
Jan 27, 2016
by
astaxie
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #1637 from pjoe/input_param_fix
Fix Context.Input.SetParam not overwriting existing value
parents
f7690161
453d744d
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
61 additions
and
0 deletions
+61
-0
input.go
context/input.go
+7
-0
input_test.go
context/input_test.go
+54
-0
No files found.
context/input.go
View file @
85c0fcd3
...
...
@@ -287,6 +287,13 @@ func (input *BeegoInput) Params() map[string]string {
// SetParam will set the param with key and value
func
(
input
*
BeegoInput
)
SetParam
(
key
,
val
string
)
{
// check if already exists
for
i
,
v
:=
range
input
.
pnames
{
if
v
==
key
&&
i
<=
len
(
input
.
pvalues
)
{
input
.
pvalues
[
i
]
=
val
return
}
}
input
.
pvalues
=
append
(
input
.
pvalues
,
val
)
input
.
pnames
=
append
(
input
.
pnames
,
key
)
}
...
...
context/input_test.go
View file @
85c0fcd3
...
...
@@ -18,6 +18,7 @@ import (
"fmt"
"net/http"
"net/http/httptest"
"reflect"
"testing"
)
...
...
@@ -117,3 +118,56 @@ func TestSubDomain(t *testing.T) {
t
.
Fatal
(
"Subdomain parse error, got "
+
beegoInput
.
SubDomains
())
}
}
func
TestParams
(
t
*
testing
.
T
)
{
inp
:=
NewInput
()
inp
.
SetParam
(
"p1"
,
"val1_ver1"
)
inp
.
SetParam
(
"p2"
,
"val2_ver1"
)
inp
.
SetParam
(
"p3"
,
"val3_ver1"
)
if
l
:=
inp
.
ParamsLen
();
l
!=
3
{
t
.
Fatalf
(
"Input.ParamsLen wrong value: %d, expected %d"
,
l
,
3
)
}
if
val
:=
inp
.
Param
(
"p1"
);
val
!=
"val1_ver1"
{
t
.
Fatalf
(
"Input.Param wrong value: %s, expected %s"
,
val
,
"val1_ver1"
)
}
if
val
:=
inp
.
Param
(
"p3"
);
val
!=
"val3_ver1"
{
t
.
Fatalf
(
"Input.Param wrong value: %s, expected %s"
,
val
,
"val3_ver1"
)
}
vals
:=
inp
.
Params
()
expected
:=
map
[
string
]
string
{
"p1"
:
"val1_ver1"
,
"p2"
:
"val2_ver1"
,
"p3"
:
"val3_ver1"
,
}
if
!
reflect
.
DeepEqual
(
vals
,
expected
)
{
t
.
Fatalf
(
"Input.Params wrong value: %s, expected %s"
,
vals
,
expected
)
}
// overwriting existing params
inp
.
SetParam
(
"p1"
,
"val1_ver2"
)
inp
.
SetParam
(
"p2"
,
"val2_ver2"
)
expected
=
map
[
string
]
string
{
"p1"
:
"val1_ver2"
,
"p2"
:
"val2_ver2"
,
"p3"
:
"val3_ver1"
,
}
vals
=
inp
.
Params
()
if
!
reflect
.
DeepEqual
(
vals
,
expected
)
{
t
.
Fatalf
(
"Input.Params wrong value: %s, expected %s"
,
vals
,
expected
)
}
if
l
:=
inp
.
ParamsLen
();
l
!=
3
{
t
.
Fatalf
(
"Input.ParamsLen wrong value: %d, expected %d"
,
l
,
3
)
}
if
val
:=
inp
.
Param
(
"p1"
);
val
!=
"val1_ver2"
{
t
.
Fatalf
(
"Input.Param wrong value: %s, expected %s"
,
val
,
"val1_ver2"
)
}
if
val
:=
inp
.
Param
(
"p2"
);
val
!=
"val2_ver2"
{
t
.
Fatalf
(
"Input.Param wrong value: %s, expected %s"
,
val
,
"val1_ver2"
)
}
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment