Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
B
beego
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
go
beego
Commits
90caeb4c
Commit
90caeb4c
authored
Oct 26, 2014
by
astaxie
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Revert "Add column default attribute"
parent
6c924903
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
1 addition
and
58 deletions
+1
-58
cmd_utils.go
orm/cmd_utils.go
+1
-52
models_info_f.go
orm/models_info_f.go
+0
-6
No files found.
orm/cmd_utils.go
View file @
90caeb4c
...
@@ -104,11 +104,7 @@ func getColumnAddQuery(al *alias, fi *fieldInfo) string {
...
@@ -104,11 +104,7 @@ func getColumnAddQuery(al *alias, fi *fieldInfo) string {
typ
+=
" "
+
"NOT NULL"
typ
+=
" "
+
"NOT NULL"
}
}
return
fmt
.
Sprintf
(
"ALTER TABLE %s%s%s ADD COLUMN %s%s%s %s %s"
,
return
fmt
.
Sprintf
(
"ALTER TABLE %s%s%s ADD COLUMN %s%s%s %s"
,
Q
,
fi
.
mi
.
table
,
Q
,
Q
,
fi
.
column
,
Q
,
typ
)
Q
,
fi
.
mi
.
table
,
Q
,
Q
,
fi
.
column
,
Q
,
typ
,
getColumnDefault
(
fi
),
)
}
}
// create database creation string.
// create database creation string.
...
@@ -159,9 +155,6 @@ func getDbCreateSql(al *alias) (sqls []string, tableIndexes map[string][]dbIndex
...
@@ -159,9 +155,6 @@ func getDbCreateSql(al *alias) (sqls []string, tableIndexes map[string][]dbIndex
//if fi.initial.String() != "" {
//if fi.initial.String() != "" {
// column += " DEFAULT " + fi.initial.String()
// column += " DEFAULT " + fi.initial.String()
//}
//}
// Append attribute DEFAULT
column
+=
getColumnDefault
(
fi
)
if
fi
.
unique
{
if
fi
.
unique
{
column
+=
" "
+
"UNIQUE"
column
+=
" "
+
"UNIQUE"
...
@@ -246,47 +239,3 @@ func getDbCreateSql(al *alias) (sqls []string, tableIndexes map[string][]dbIndex
...
@@ -246,47 +239,3 @@ func getDbCreateSql(al *alias) (sqls []string, tableIndexes map[string][]dbIndex
return
return
}
}
// Get string value for the attribute "DEFAULT" for the CREATE, ALTER commands
func
getColumnDefault
(
fi
*
fieldInfo
)
string
{
var
(
v
,
t
,
d
string
)
// Skip default attribute if field is in relations
if
fi
.
rel
||
fi
.
reverse
{
return
v
}
t
=
" DEFAULT '%s' "
// These defaults will be useful if there no config value orm:"default" and NOT NULL is on
switch
fi
.
fieldType
{
case
TypeDateField
:
d
=
"0000-00-00"
case
TypeDateTimeField
:
d
=
"0000-00-00 00:00:00"
case
TypeBooleanField
,
TypeBitField
,
TypeSmallIntegerField
,
TypeIntegerField
,
TypeBigIntegerField
,
TypePositiveBitField
,
TypePositiveSmallIntegerField
,
TypePositiveIntegerField
,
TypePositiveBigIntegerField
,
TypeFloatField
,
TypeDecimalField
:
d
=
"0"
}
if
fi
.
colDefault
{
if
!
fi
.
initial
.
Exist
()
{
v
=
fmt
.
Sprintf
(
t
,
""
)
}
else
{
v
=
fmt
.
Sprintf
(
t
,
fi
.
initial
.
String
())
}
}
else
{
if
!
fi
.
null
{
v
=
fmt
.
Sprintf
(
t
,
d
)
}
}
return
v
}
orm/models_info_f.go
View file @
90caeb4c
...
@@ -116,7 +116,6 @@ type fieldInfo struct {
...
@@ -116,7 +116,6 @@ type fieldInfo struct {
null
bool
null
bool
index
bool
index
bool
unique
bool
unique
bool
colDefault
bool
initial
StrTo
initial
StrTo
size
int
size
int
auto_now
bool
auto_now
bool
...
@@ -281,11 +280,6 @@ checkType:
...
@@ -281,11 +280,6 @@ checkType:
fi
.
pk
=
attrs
[
"pk"
]
fi
.
pk
=
attrs
[
"pk"
]
fi
.
unique
=
attrs
[
"unique"
]
fi
.
unique
=
attrs
[
"unique"
]
// Mark object property if there is attribute "default" in the orm configuration
if
_
,
ok
:=
tags
[
"default"
];
ok
{
fi
.
colDefault
=
true
}
switch
fieldType
{
switch
fieldType
{
case
RelManyToMany
,
RelReverseMany
,
RelReverseOne
:
case
RelManyToMany
,
RelReverseMany
,
RelReverseOne
:
fi
.
null
=
false
fi
.
null
=
false
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment