Fix http body may not be closed

9ff88f0b · cat2neat · 27c59a80 · 9ff88f0b · 9ff88f0b
Commit 9ff88f0b authored Nov 20, 2016 by cat2neat
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

jianliao.go logs/jianliao.go +1 -1

slack.go logs/slack.go +1 -1

No files found.
--- a/logs/jianliao.go
+++ b/logs/jianliao.go
@@ -56,10 +56,10 @@ func (s *JLWriter) WriteMsg(when time.Time, msg string, level int) error {
 	if err != nil {
 		return err
 	}
+	defer resp.Body.Close()
 	if resp.StatusCode != http.StatusOK {
 		return fmt.Errorf("Post webhook failed %s %d", resp.Status, resp.StatusCode)
 	}
-	resp.Body.Close()
 	return nil
 }


--- a/logs/slack.go
+++ b/logs/slack.go
@@ -44,10 +44,10 @@ func (s *SLACKWriter) WriteMsg(when time.Time, msg string, level int) error {
 	if err != nil {
 		return err
 	}
+	defer resp.Body.Close()
 	if resp.StatusCode != http.StatusOK {
 		return fmt.Errorf("Post webhook failed %s %d", resp.Status, resp.StatusCode)
 	}
-	resp.Body.Close()
 	return nil
 }