Commit c16b7be9 authored by smallfish's avatar smallfish

rollback the ToFile func implement, and add testcase

parent de875293
...@@ -421,11 +421,15 @@ func (b *BeegoHttpRequest) ToFile(filename string) error { ...@@ -421,11 +421,15 @@ func (b *BeegoHttpRequest) ToFile(filename string) error {
} }
defer f.Close() defer f.Close()
data, err := b.Bytes() resp, err := b.getResponse()
if err != nil { if err != nil {
return err return err
} }
_, err = f.Write(data) if resp.Body == nil {
return nil
}
defer resp.Body.Close()
_, err = io.Copy(f, resp.Body)
return err return err
} }
......
...@@ -15,6 +15,8 @@ ...@@ -15,6 +15,8 @@
package httplib package httplib
import ( import (
"io/ioutil"
"os"
"strings" "strings"
"testing" "testing"
) )
...@@ -41,6 +43,10 @@ func TestGet(t *testing.T) { ...@@ -41,6 +43,10 @@ func TestGet(t *testing.T) {
t.Fatal(err) t.Fatal(err)
} }
t.Log(s) t.Log(s)
if string(b) != s {
t.Fatal("request data not match")
}
} }
func TestSimplePost(t *testing.T) { func TestSimplePost(t *testing.T) {
...@@ -171,3 +177,17 @@ func TestToJson(t *testing.T) { ...@@ -171,3 +177,17 @@ func TestToJson(t *testing.T) {
t.Fatal("response is not valid ip") t.Fatal("response is not valid ip")
} }
} }
func TestToFile(t *testing.T) {
f := "beego_testfile"
req := Get("http://httpbin.org/ip")
err := req.ToFile(f)
if err != nil {
t.Fatal(err)
}
defer os.Remove(f)
b, err := ioutil.ReadFile(f)
if n := strings.Index(string(b), "origin"); n == -1 {
t.Fatal(err)
}
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment