Skip to content
Projects
Groups
Snippets
Help
Loading...
Sign in
Toggle navigation
D
dex
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Commits
Issue Boards
Open sidebar
go
dex
Commits
91cc94dd
Commit
91cc94dd
authored
Dec 13, 2016
by
Eric Chiang
Committed by
GitHub
Dec 13, 2016
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #740 from ericchiang/fix-comment-typos
*: fix comment typos and add go report card icon
parents
aa6c0c6e
998350db
Hide whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
6 additions
and
5 deletions
+6
-5
README.md
README.md
+1
-0
templates.go
cmd/example-app/templates.go
+1
-1
api.go
server/api.go
+1
-1
templates.go
server/templates.go
+1
-1
conformance.go
storage/conformance/conformance.go
+1
-1
crud.go
storage/sql/crud.go
+1
-1
No files found.
README.md
View file @
91cc94dd
...
...
@@ -2,6 +2,7 @@
[
![Travis
](
https://api.travis-ci.org/coreos/dex.svg
)
](https://travis-ci.org/coreos/dex)
[
![GoDoc
](
https://godoc.org/github.com/coreos/dex?status.svg
)
](https://godoc.org/github.com/coreos/dex)
[
![Go Report Card
](
https://goreportcard.com/badge/github.com/coreos/dex
)
](https://goreportcard.com/report/github.com/coreos/dex)
![
logo
](
Documentation/logos/dex-horizontal-color.png
)
...
...
cmd/example-app/templates.go
View file @
91cc94dd
...
...
@@ -70,7 +70,7 @@ func renderTemplate(w http.ResponseWriter, tmpl *template.Template, data interfa
switch
err
:=
err
.
(
type
)
{
case
*
template
.
Error
:
// An ExecError guar
e
ntees that Execute has not written to the underlying reader.
// An ExecError guar
a
ntees that Execute has not written to the underlying reader.
log
.
Printf
(
"Error rendering template %s: %s"
,
tmpl
.
Name
(),
err
)
// TODO(ericchiang): replace with better internal server error.
...
...
server/api.go
View file @
91cc94dd
...
...
@@ -13,7 +13,7 @@ import (
"github.com/coreos/dex/version"
)
// apiVersion increases everytime a new call is added to the API. Clients should use this info
// apiVersion increases every
time a new call is added to the API. Clients should use this info
// to determine if the server supports specific features.
const
apiVersion
=
0
...
...
server/templates.go
View file @
91cc94dd
...
...
@@ -222,7 +222,7 @@ func (t *templates) oob(w http.ResponseWriter, code string) error {
return
renderTemplate
(
w
,
t
.
oobTmpl
,
data
)
}
// small io.Writer utilit
i
y to determine if executing the template wrote to the underlying response writer.
// small io.Writer utility to determine if executing the template wrote to the underlying response writer.
type
writeRecorder
struct
{
wrote
bool
w
io
.
Writer
...
...
storage/conformance/conformance.go
View file @
91cc94dd
...
...
@@ -62,7 +62,7 @@ func mustLoadJWK(b string) *jose.JSONWebKey {
func
mustBeErrNotFound
(
t
*
testing
.
T
,
kind
string
,
err
error
)
{
switch
{
case
err
==
nil
:
t
.
Errorf
(
"deleting non-exist
a
nt %s should return an error"
,
kind
)
t
.
Errorf
(
"deleting non-exist
e
nt %s should return an error"
,
kind
)
case
err
!=
storage
.
ErrNotFound
:
t
.
Errorf
(
"deleting %s expected storage.ErrNotFound, got %v"
,
kind
,
err
)
}
...
...
storage/sql/crud.go
View file @
91cc94dd
...
...
@@ -13,7 +13,7 @@ import (
)
// TODO(ericchiang): The update, insert, and select methods queries are all
// very repeti
vite. Consider creating them progra
matically.
// very repeti
tive. Consider creating them program
matically.
// keysRowID is the ID of the only row we expect to populate the "keys" table.
const
keysRowID
=
"keys"
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment