prior to this change, many of the functions in the ExecTx callback would
wrap the error before returning it. this made it impossible to check
for the error code.

instead, the error wrapping has been moved to be external to the
`ExecTx` callback, so that the error code can be checked and
serialization failures can be retried.

also use a context for the rollback, which is a bit cleaner since it
only results in one 'defer', rather than N from the loop

pg: support host:port for backwards-compatibility

Add 'both' option to use team name AND slug in TeamNameField

This allows the connector to be configured with both so that both team names and slugs can be returned in the groups. This makes configuring teams in an application a bit more foolproof; we would often have confusion over whether the team name or slug should be given by the user, so it's easier to just allow both, since collisions shouldn't be possible anyway.

this will result in both the team name *and* the team slug being
returned for each team, allowing a bit more flexibility in auth
validation.
Signed-off-by: Topher Bullock <tbullock@pivotal.io>
Signed-off-by: Alex Suraci <suraci.alex@gmail.com>

Use pq connection parameters instead of URLs for postgres connections

This enables the use of socket paths like /var/run/postgresql for the 'host' instead of requiring TCP. Also, we know allow using a non-default port.

otherwise it's impossible to use a Unix socket, as the path gets escaped
awkwardly.
Signed-off-by: Ciro S. Costa <cscosta@pivotal.io>
Signed-off-by: Alex Suraci <suraci.alex@gmail.com>

Add config to explicitly enable loading all github groups

Follow-up for #1102.

Gitlab connector should not require the api scope.

Fixes #1347.

remove incomplete mysql and cockroachdb support

update go-ldap, improve errors

Issue #1184 - Github connector now returns a full group list when no org is specified

fix bogus conformance failure due to time zones

this failed on my machine due to the unexported 'loc' field of the time
structure - it was nil in one and set to a ton of tiemzone data in the
other. instead let's just compare the unix timestamp value and zero it
out for the struct comparison.

Issue #1263 - Render error message provided by connector if user authentication failed

Signed-off-by: Stephan Renatus <srenatus@chef.io>

Signed-off-by: Stephan Renatus <srenatus@chef.io>

Signed-off-by: Stephan Renatus <srenatus@chef.io>

point users to storage/RBAC docs

allow it to disable CRD creation