1. 04 Apr, 2017 1 commit
    • Eric Chiang's avatar
      connector/saml: fix validation bug with multiple Assertion elements · e0709dc2
      Eric Chiang authored
      When a SAML response provided multiple Assertion elements, only the
      first one is checked for a valid signature. If the Assertion is
      verified, the original Assertion is removed and the canonicalized
      version is prepended to the Response. However, if there were
      multiple assertions, the second assertion could end up first in the
      list of Assertions, even if it was unsigned.
      
      For example this:
      
          <Response>
            <!--
               Response unsigned. According to SAML spec must check
               assertion signature.
            -->
            <Assertion>
              <Signature>
                <!-- Correrctly signed assertion -->
              </Signature>
            </Assertion>
      
            <Assertion>
              <!-- Unsigned assertion inserted by attacker-->
            </Assertion>
          </Response>
      
      could be verified then re-ordered to the following:
      
          <Response>
            <!--
               Response unsigned. According to SAML spec must check
               assertion signature.
            -->
            <Assertion>
              <!-- Unsigned assertion inserted by attacker-->
            </Assertion>
      
            <Assertion>
              <!-- Canonicalized, correrctly signed assertion -->
            </Assertion>
          </Response>
      
      Fix this by removing all unverified child elements of the Response,
      not just the original assertion.
      e0709dc2
  2. 29 Mar, 2017 4 commits
  3. 28 Mar, 2017 4 commits
  4. 24 Mar, 2017 7 commits
  5. 23 Mar, 2017 3 commits
  6. 22 Mar, 2017 2 commits
  7. 21 Mar, 2017 3 commits
  8. 20 Mar, 2017 7 commits
  9. 17 Mar, 2017 3 commits
  10. 16 Mar, 2017 1 commit
  11. 15 Mar, 2017 2 commits
  12. 13 Mar, 2017 2 commits
  13. 10 Mar, 2017 1 commit