Skip to content

G
go-gitlab
Switch branch/tag
  1. 04 Jan, 2016 1 commit
  3. 19 Dec, 2015 3 commits
  5. 09 Dec, 2015 1 commit
  7. 03 Dec, 2015 2 commits
  9. 02 Dec, 2015 3 commits
  11. 27 Nov, 2015 3 commits
  13. 24 Nov, 2015 5 commits
  15. 23 Nov, 2015 3 commits
  17. 22 Nov, 2015 1 commit
  19. 06 Nov, 2015 1 commit
  21. 05 Nov, 2015 3 commits
  23. 04 Nov, 2015 1 commit
  25. 03 Nov, 2015 3 commits
  27. 30 Sep, 2015 2 commits
  29. 22 Sep, 2015 4 commits
  31. 07 Sep, 2015 3 commits
  33. 06 Sep, 2015 1 commit
    • Calin Seciu's avatar
      Don't add the host into the url opaque param · d5e2e8d0
      Calin Seciu authored 
      Adding the host into the URL.Opaque parameter creates an absolute
uri request like:

    GET https://gitlab.com/api/v3/... HTTP/1.1

instead of:

    GET /api/v3/... HTTP/1.1

Apache seems to have a problem with absolute uri requests when used
as a reversed proxy, double encoding %2F to %252F before passing the
request to GitLab, which breaks GitLab's api that accepts NAMESPACE/PROJECT.

The proxy config used is:

    ProxyPass / http://127.0.0.1:8080/ nocanon

'nocanon' parameter is the one that prevents double encoding, but it
seems to work only for relative uri requests.

An alternative is to use the mod_rewrite module directly instead of
the ProxyPass directive as:

    RewriteEngine On
    RewriteRule ^(.*) http://127.0.0.1:8080$1 [NE,P]

with the 'NE' flag (no escape) which works fine with absolute uri
requests. There are performance issues with this method as explained
here http://httpd.apache.org/docs/current/rewrite/flags.html#flag_p
      d5e2e8d0