• Matthew Dempsky's avatar
    runtime/internal/atomic: remove bad go:noescape annotations on Loadp · 9dce58d3
    Matthew Dempsky authored
    The //go:noescape directive says that arguments don't leak at all,
    which is too aggressive of a claim for functions that return pointers
    derived from their parameters.
    
    Remove the directive for now. Long term fix will require a new
    directive that allows more fine-grained control over escape analysis
    information supplied for functions implemented in assembly.
    
    Also, update the BAD comments in the test cases for Loadp: we really
    want that *ptr leaks to the result parameter, not that *ptr leaks to
    the heap.
    
    Updates #31525.
    
    Change-Id: Ibfa61f2b70daa7ed3223056b57eeee777eef2e31
    Reviewed-on: https://go-review.googlesource.com/c/go/+/172578
    Run-TryBot: Matthew Dempsky <mdempsky@google.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarAustin Clements <austin@google.com>
    9dce58d3