• Raul Silvera's avatar
    test: improve test coverage for heap sampling · 2dd066d4
    Raul Silvera authored
    Update the test in test/heapsampling.go to more thoroughly validate heap sampling.
    Lower the sampling rate on the test to ensure allocations both smaller and
    larger than the sampling rate are tested.
    
    Tighten up the validation check to a 10% difference between the unsampled and correct value.
    Because of the nature of random sampling, it is possible that the unsampled value fluctuates
    over that range. To avoid flakes, run the experiment three times and only report an issue if the
    same location consistently falls out of range on all experiments.
    
    This tests the sampling fix in cl/158337.
    
    Change-Id: I54a709e5c75827b8b1c2d87cdfb425ab09759677
    GitHub-Last-Rev: 7c04f126034f9e323efc220c896d75e7984ffd39
    GitHub-Pull-Request: golang/go#26944
    Reviewed-on: https://go-review.googlesource.com/c/go/+/129117
    Run-TryBot: Austin Clements <austin@google.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarAustin Clements <austin@google.com>
    2dd066d4