• Joe Tsai's avatar
    compress/gzip: only encode MTIME if it is valid · b4e714e5
    Joe Tsai authored
    The GZIP format records the ModTime as an uint32 counting seconds since
    the Unix epoch. The zero value is explicitly defined in section 2.3.1
    as meaning no timestamp is available.
    
    Currently, the Writer always encodes the ModTime even if it is the zero
    time.Time value, which causes the Writer to try and encode the value
    -62135596800 into the uint32 MTIME field. This causes an overflow and
    results in our GZIP files having MTIME fields indicating a date in 2042-07-13.
    
    We alter the Writer to only encode ModTime if the value does not underflow
    the MTIME field (i.e., it is newer than the Unix epoch). We do not attempt
    to fix what happens when the timestamp overflows in the year 2106.
    
    We alter the Reader to only decode ModTime if the value is non-zero.
    There is no risk of overflowing time.Time when decoding.
    
    Fixes #17663
    
    Change-Id: Ie1b65770c6342cd7b14aeebe10e5a49e6c9eb730
    Reviewed-on: https://go-review.googlesource.com/32325Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
    Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    b4e714e5
gunzip.go 8.41 KB