• Keith Randall's avatar
    cmd/compile: don't constant-fold non-Go constants in the frontend · 1602e497
    Keith Randall authored
    Abort evconst if its argument isn't a Go constant. The SSA backend
    will do the optimizations in question later. They tend to be weird
    cases, like uintptr(unsafe.Pointer(uintptr(1))).
    
    Fix OADDSTR and OCOMPLEX cases in isGoConst.
    OADDSTR has its arguments in n.List, not n.Left and n.Right.
    OCOMPLEX might have a 2-result function as its arg in List[0]
    (in which case it isn't a Go constant).
    
    Fixes #24760
    
    Change-Id: Iab312d994240d99b3f69bfb33a443607e872b01d
    Reviewed-on: https://go-review.googlesource.com/c/151338
    Run-TryBot: Keith Randall <khr@golang.org>
    Reviewed-by: 's avatarMatthew Dempsky <mdempsky@google.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    1602e497
fmt.go 40.8 KB