• Ian Lance Taylor's avatar
    syscall: support Faccessat flags argument · d9705190
    Ian Lance Taylor authored
    The Linux kernel faccessat system call does not take a flags parameter.
    The flag parameter to the C library faccessat function is implemented in C.
    The syscall.Faccessat function takes a flags parameter. In older releases
    we have passed the flags parameter to the kernel, which ignored it.
    In CL 120015 we started returning an error if any flags were set.
    That seems clearly better than ignoring them, but it turns out that some
    code was using the flags. The code was previously subtly broken.
    Now it is obviously broken. That is better, but we can do better still:
    we can implement the flags as the C library does. That is what this CL does.
    
    Change-Id: I259bd6f240c3951e939b81c3032dead3d9c567b4
    Reviewed-on: https://go-review.googlesource.com/126415
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
    d9705190
syscall_linux_test.go 9.8 KB