• Ian Lance Taylor's avatar
    net: don't accept timeouts in TestUDPZeroBytePayload · 0dd88cd5
    Ian Lance Taylor authored
    Before this CL we accepted timeouts in TestUDPZeroBytePayload to avoid
    flakiness and because, according to CL 9194, the test didn't work on
    some platforms. On Windows, before CL 132781, the read would always
    timeout, and so since the test accepted timeouts it would pass
    incorrectly. CL 132781 fixed Windows, and changed the test to not
    accept timeouts in the ReadFrom case.
    
    However, the timeout was short, and so on a loaded system the Read
    might timeout not due to an error in the code, but just because the
    read was not delivered. So ignoring timeouts made the test flaky, as
    reported in issue #29225.
    
    This CL tries to get to a better state by increasing the timeout to a
    large value and not permitting timeouts at all. If there are systems
    where the test fails, we will need to explicitly skip the test on
    those systems.
    
    Fixes #29225
    
    Change-Id: I26863369898a69cac866b34fcb5b6ffbffab31f6
    Reviewed-on: https://go-review.googlesource.com/c/154759
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarAlex Brainman <alex.brainman@gmail.com>
    Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
    0dd88cd5
udpsock_test.go 11.4 KB