• Russ Cox's avatar
    regexp: revert "use sync.Pool to cache regexp.machine objects" · a41d2169
    Russ Cox authored
    Revert CL 101715.
    
    The size of a sync.Pool scales linearly with GOMAXPROCS,
    making it inappropriate to put a sync.Pool in any individually
    allocated object, as the sync.Pool documentation explains.
    The change also broke DeepEqual on regexps.
    
    I have a cleaner way to do this with global sync.Pools but it's
    too late in the cycle. Will revisit in Go 1.12. For now, revert.
    
    Fixes #26219.
    
    Change-Id: Ie632e709eb3caf489d85efceac0e4b130ec2019f
    Reviewed-on: https://go-review.googlesource.com/122596
    Run-TryBot: Russ Cox <rsc@golang.org>
    Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    a41d2169
regexp.go 34.9 KB