• Russ Cox's avatar
    cmd/pack: fix match · 258c278e
    Russ Cox authored
    Match used len(ar.files) == 0 to mean "match everything"
    but it also deleted matched things from the list, so once you
    had matched everything you asked for, match returned true
    for whatever was left in the archive too.
    
    Concretely, if you have an archive containing f1, f2, then
            pack t foo.a f1
    would match f1 and then, because len(ar.files) == 0 after
    deleting f1 from the match list, also match f2.
    
    Avoid the problem by recording explicitly whether match
    matches everything.
    
    LGTM=r, dsymonds
    R=r, dsymonds
    CC=golang-codereviews
    https://golang.org/cl/65630046
    258c278e
pack_test.go 7.02 KB