• Nigel Tao's avatar
    image/gif: fix frame-inside-image bounds checking. · 9ef65dbe
    Nigel Tao authored
    The semantics of the Go image.Rectangle type is that the In and
    Intersects methods treat empty rectangles specially. There are multiple
    valid representations of an empty image.Rectangle. One of them is the
    zero image.Rectangle but there are others. They're obviously not all
    equal in the == sense, so we shouldn't use != to check GIF's semantics.
    
    This change will allow us to re-roll
    a855da29 "image: fix the overlap check
    in Rectangle.Intersect" which was rolled back in
    14347ee4.
    
    Change-Id: Ie1a0d092510a7bb6170e61adbf334b21361ff9e6
    Reviewed-on: https://go-review.googlesource.com/36639
    Run-TryBot: Nigel Tao <nigeltao@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarRob Pike <r@golang.org>
    9ef65dbe
reader.go 15.1 KB