• David Chase's avatar
    cmd/compile: check for negative upper bound to IsSliceInBounds · ea6259d5
    David Chase authored
    IsSliceInBounds(x, y) asserts that y is not negative, but
    there were cases where this is not true.  Change code
    generation to ensure that this is true when it's not obviously
    true.  Prove phase cleans a few of these out.
    
    With this change the compiler text section is 0.06% larger,
    that is, not very much.  Benchmarking still TBD, may need
    to wait for access to a benchmarking box (next week).
    
    Also corrected run.go to handle '?' in -update_errors output.
    
    Fixes #28797.
    
    Change-Id: Ia8af90bc50a91ae6e934ef973def8d3f398fac7b
    Reviewed-on: https://go-review.googlesource.com/c/152477
    Run-TryBot: David Chase <drchase@google.com>
    Reviewed-by: 's avatarKeith Randall <khr@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    ea6259d5
loopbce.go 8.85 KB