• Elias Naur's avatar
    net: skip external net tests on iOS · 74604bb5
    Elias Naur authored
    CL 113095 tried to deflake net tests on iOS by skipping the test
    that uses the most sockets. That didn't work well enough and will
    be reverted in CL 113555.
    
    The flakes appeared after the iOS exec harness started to forward
    environment variables, causing testenv.Builder to be non-empty on
    the iOS builder. This CL attempts to fix the flakes with the more
    conservative strategy of skipping tests that only run on builders.
    
    The skipped tests happen to be those requiring external network
    access; it's plausible that the iOS builder network isn't reliable
    enough to run the many parallel DNS lookups and dial outs, while
    keeping the number of open file descriptors below the 250 limit.
    
    Change-Id: I9cafdaf2845dd6f3844c4819dcaaaa5970f5da15
    Reviewed-on: https://go-review.googlesource.com/113575
    Run-TryBot: Elias Naur <elias.naur@gmail.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
    74604bb5
dial_test.go 24.4 KB