• Russ Cox's avatar
    net/http: better failure in TestTransportPersistConnLeak · cb91dccd
    Russ Cox authored
    If one of the c.Get(ts.URL) results in an error, the child goroutine
    calls t.Errorf, but the test goroutine gets stuck waiting for <-gotReqCh,
    so the test hangs and the program is eventually killed (after 10 minutes!).
    Whatever might have been printed to t.Errorf is never seen.
    Adjust test so that the test fails cleanly in this case.
    
    Still trying to debug why c.Get might fail.
    It seems to have something to do with occasional connection
    failures on macOS Sierra.
    
    Change-Id: Ia797787bd51ea7cd6deb1192aec89c331c4f2c48
    Reviewed-on: https://go-review.googlesource.com/34836
    Run-TryBot: Russ Cox <rsc@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
    cb91dccd
transport_test.go 103 KB