• Keith Randall's avatar
    cmd/compile: fix type of static closure pointer · 88d2f911
    Keith Randall authored
      var x *X = ...
      defer x.foo()
    
    As part of the defer, we need to calculate &(*X).foo·f.  This expression
    is the address of the static closure that will call (*X).foo when a
    pointer to that closure is used in a call/defer/go.  This pointer is not
    currently properly typed in SSA.  It is a pointer type, but the base
    type is nil, not a proper type.
    
    This turns out not to be a problem currently because we never use the
    type of these SSA values.  But I'm trying to change that (to be able to
    spill them) in CL 28391.  To fix, use uint8 as the fake type of the
    closure.
    
    Change-Id: Ieee388089c9af398ed772ee8c815122c347cb633
    Reviewed-on: https://go-review.googlesource.com/29444
    Run-TryBot: Keith Randall <khr@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarMatthew Dempsky <mdempsky@google.com>
    88d2f911
subr.go 48.9 KB