• Austin Clements's avatar
    runtime: enable GC assists ASAP · 510fd135
    Austin Clements authored
    Currently the GC coordinator enables GC assists at the same time it
    enables background mark workers, after the concurrent scan phase is
    done. However, this means a rapidly allocating mutator has the entire
    scan phase during which to allocate beyond the heap trigger and
    potentially beyond the heap goal with no back-pressure from assists.
    This prevents the feedback system that's supposed to keep the heap
    size under the heap goal from doing its job.
    
    Fix this by enabling mutator assists during the scan phase. This is
    safe because the write barrier is already enabled and globally
    acknowledged at this point.
    
    There's still a very small window between when the heap size reaches
    the heap trigger and when the GC coordinator is able to stop the world
    during which the mutator can allocate unabated. This allows *very*
    rapidly allocator mutators like TestTraceStress to still occasionally
    exceed the heap goal by a small amount (~20 MB at most for
    TestTraceStress). However, this seems like a corner case.
    
    Fixes #11677.
    
    Change-Id: I0f80d949ec82341cd31ca1604a626efb7295a819
    Reviewed-on: https://go-review.googlesource.com/12674Reviewed-by: 's avatarRuss Cox <rsc@golang.org>
    510fd135
mgcmark.go 30.4 KB