• Austin Clements's avatar
    runtime: fail silently if we unwind over sigpanic into C code · ebe38b86
    Austin Clements authored
    If we're running C code and the code panics, the runtime will inject a
    call to sigpanic into the C code just like it would into Go code.
    However, the return PC from this sigpanic will be in C code. We used
    to silently abort the traceback if we didn't recognize a return PC, so
    this went by quietly. Now we're much louder because in general this is
    a bad thing. However, in this one particular case, it's fine, so if
    we're in cgo and are looking at the return PC of sigpanic, silence the
    debug output.
    
    Fixes #23576.
    
    Change-Id: I03d0c14d4e4d25b29b1f5804f5e9ccc4f742f876
    Reviewed-on: https://go-review.googlesource.com/90896
    Run-TryBot: Austin Clements <austin@google.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
    ebe38b86
crash_cgo_test.go 12.6 KB