• Austin Clements's avatar
    runtime: fix write-barrier-enabled phase list in gcmarkwb_m · b0532a96
    Austin Clements authored
    Commit 1303957d was supposed to enable write barriers during the
    concurrent scan phase, but it only enabled *calls* to the write
    barrier during this phase. It failed to update the redundant list of
    write-barrier-enabled phases in gcmarkwb_m, so it still wasn't greying
    objects during the scan phase.
    
    This commit fixes this by replacing the redundant list of phases in
    gcmarkwb_m with simply checking writeBarrierEnabled. This is almost
    certainly redundant with checks already done in callers, but the last
    time we tried to remove these redundant checks everything got much
    slower, so I'm leaving it alone for now.
    
    Fixes #11105.
    
    Change-Id: I00230a3cb80a008e749553a8ae901b409097e4be
    Reviewed-on: https://go-review.googlesource.com/10801
    Run-TryBot: Austin Clements <austin@google.com>
    Reviewed-by: 's avatarMinux Ma <minux@golang.org>
    b0532a96
mbarrier.go 9.32 KB