• Austin Clements's avatar
    runtime: fix sanity check in stackBarrier · bb6fb929
    Austin Clements authored
    stackBarrier on amd64 sanity checks that it's unwinding the correct
    entry in the stack barrier array. However, this check is wrong in two
    ways that make it unlikely to catch anything, right or wrong:
    
    1) It checks that savedLRPtr == SP, but, in fact, it should be that
       savedLRPtr+8 == SP because the RET that returned to stackBarrier
       popped the saved LR. However, we didn't notice this check was wrong
       because,
    
    2) the sense of the conditional branch is also wrong.
    
    Fix both of these.
    
    Change-Id: I38ba1f652b0168b5b2c11b81637656241262af7c
    Reviewed-on: https://go-review.googlesource.com/17039Reviewed-by: 's avatarRuss Cox <rsc@golang.org>
    bb6fb929
asm_amd64.s 44.1 KB