• Josh Bleecher Snyder's avatar
    cmd/compile: clean up SSA test API · a68e5d94
    Josh Bleecher Snyder authored
    I noted in CL 38327 that the SSA test API felt a bit
    clunky after the ssa.Func/ssa.Cache/ssa.Config refactoring,
    and promised to clean it up once the dust settled.
    The dust has settled.
    
    Along the way, this CL fixes a potential latent bug,
    in which the amd64 test context was used for all dummy Syslook calls.
    The lone SSA test using the s390x context did not depend on the
    Syslook context being correct, so the bug did not arise in practice.
    
    Change-Id: If964251d1807976073ad7f47da0b1f1f77c58413
    Reviewed-on: https://go-review.googlesource.com/38346
    Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
    Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
    a68e5d94
nilcheck_test.go 12 KB