• Joe Tsai's avatar
    archive/tar: ignore ChangeTime and AccessTime unless Format is specified · 577aab0c
    Joe Tsai authored
    CL 59230 changed Writer.WriteHeader to ignore the ChangeTime and AccessTime
    fields when considering using the USTAR format when the format is unspecified.
    This policy is confusing and leads to unexpected behavior where some files
    have ModTime only, while others have ModTime+AccessTime+ChangeTime if the
    format became PAX for some unrelated reason (e.g., long pathname).
    
    Change the policy to simply always ignore ChangeTime, AccessTime, and
    sub-second time resolutions unless the user explicitly specifies a format.
    This is a safe policy change since WriteHeader had no support for the
    above features in any Go release.
    
    Support for ChangeTime and AccessTime was added in CL 55570.
    Support for sub-second times was added in CL 55552.
    Both CLs landed after the latest Go release (i.e., Go1.9), which was
    cut from the master branch around August 6th, 2017.
    
    Change-Id: Ib82baa1bf9dd4573ed4f674b7d55d15f733a4843
    Reviewed-on: https://go-review.googlesource.com/69296Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
    Run-TryBot: Ian Lance Taylor <iant@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    577aab0c
tar_test.go 28 KB