• Keith Randall's avatar
    cmd/compile: remove Symbol wrappers from Aux fields · 1787ced8
    Keith Randall authored
    We used to have {Arg,Auto,Extern}Symbol structs with which we wrapped
    a *gc.Node or *obj.LSym before storing them in the Aux field
    of an ssa.Value.  This let the SSA part of the compiler distinguish
    between autos and args, for example.  We no longer need the wrappers
    as we can query the underlying objects directly.
    
    There was also some sloppy usage, where VarDef had a *gc.Node
    directly in its Aux field, whereas the use of that variable had
    that *gc.Node wrapped in an AutoSymbol. Thus the Aux fields didn't
    match (using ==) when they probably should.
    This sloppy usage cleanup is the only thing in the CL that changes the
    generated code - we can get rid of some more unused auto variables if
    the matching happens reliably.
    
    Removing this wrapper also lets us get rid of the varsyms cache
    (which was used to prevent wrapping the same *gc.Node twice).
    
    Change-Id: I0dedf8f82f84bfee413d310342b777316bd1d478
    Reviewed-on: https://go-review.googlesource.com/64452
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarMatthew Dempsky <mdempsky@google.com>
    1787ced8
op.go 5.1 KB